President Trump will discuss security and investment with Crown Prince Mohammed bin Salman, Saudi Arabia’s de facto ruler, who is making his first U.S. visit since the 2018 killing of a prominent critic.